aboutsummaryrefslogtreecommitdiff
path: root/packages/server/src/git/http.ts
diff options
context:
space:
mode:
authorHampusM <hampus@hampusmat.com>2021-07-25 12:06:10 +0200
committerHampusM <hampus@hampusmat.com>2021-07-25 12:06:10 +0200
commitf3ef0dd8f247f06f016fe78012fa9f2753c96479 (patch)
tree994e5de46100b2d0b5369707564f5d15f5709a25 /packages/server/src/git/http.ts
parent2819b2672d604d692dc53c94bb3020c6a03d61bc (diff)
Removed the verifyGitRequest function
Diffstat (limited to 'packages/server/src/git/http.ts')
-rw-r--r--packages/server/src/git/http.ts12
1 files changed, 6 insertions, 6 deletions
diff --git a/packages/server/src/git/http.ts b/packages/server/src/git/http.ts
index 76a91d9..36bae04 100644
--- a/packages/server/src/git/http.ts
+++ b/packages/server/src/git/http.ts
@@ -3,7 +3,6 @@ import { Repository } from "./repository";
import { Route } from "../types/fastify";
import { join } from "path";
import { spawn } from "child_process";
-import { verifyGitRequest } from "../api/util";
export interface Request extends FastifyRequest {
params: Route["Params"],
@@ -28,16 +27,17 @@ export function connect(repository: Repository, req: Request, reply: FastifyRepl
const content_type = `application/x-${service}-${is_discovery ? "advertisement" : "result"}`;
- const valid_request = verifyGitRequest(parsed_url.pathname, service);
- if(valid_request.success === false && valid_request.code) {
+ // Deny any malicious requests
+ if(/\.\/|\.\./u.test(parsed_url.pathname) || service !== "git-upload-pack") {
reply.header("Content-Type", content_type);
- reply.code(valid_request.code).send(valid_request.message);
+ reply.code(403).send("Access denied!");
return;
}
reply.raw.writeHead(200, { "Content-Type": content_type });
const spawn_args = [ "--stateless-rpc", join(repository.base_dir, repository.name.full) ];
+
if(is_discovery) {
spawn_args.push("--advertise-refs");
}
@@ -58,6 +58,8 @@ export function connect(repository: Repository, req: Request, reply: FastifyRepl
});
}
+ git_service.stdout.pipe(reply.raw);
+
// Spawn error
git_service.on("error", err => {
console.log(err);
@@ -69,6 +71,4 @@ export function connect(repository: Repository, req: Request, reply: FastifyRepl
console.log(stderr.toString());
reply.raw.end();
});
-
- git_service.stdout.pipe(reply.raw);
} \ No newline at end of file