fix(engine): remove useless tracing instrumentation of gl debug message cb fn

1 files changed, 9 insertions, 13 deletions

diff --git a/engine/src/rendering/backend/opengl.rs b/engine/src/rendering/backend/opengl.rs
index 9df21c4..a85b6da 100644
--- a/engine/src/rendering/backend/opengl.rs
+++ b/engine/src/rendering/backend/opengl.rs
@@ -1895,7 +1895,8 @@ enum CreateShaderError
     ShaderError(#[from] GlShaderError),
 }
 
-#[tracing::instrument(skip_all)]
+// This function not having tracing instrumentation is intentional. It would not provide
+// any value
 fn opengl_debug_message_cb(
     source: MessageSource,
     ty: MessageType,
@@ -1904,13 +1905,9 @@ fn opengl_debug_message_cb(
     message: &str,
 )
 {
-    use std::backtrace::{Backtrace, BacktraceStatus};
-
-    use tracing::{event, Level};
-
-    macro_rules! create_event {
+    macro_rules! emit_log_with_message {
         ($level: expr) => {
-            event!($level, ?source, ?ty, id, ?severity, message);
+            tracing::event!($level, ?source, ?ty, id, ?severity, "{message}");
         };
     }
 
@@ -1920,20 +1917,19 @@ fn opengl_debug_message_cb(
 
     match ty {
         MessageType::Error => {
-            create_event!(Level::ERROR);
+            emit_log_with_message!(tracing::Level::ERROR);
 
-            let backtrace = Backtrace::capture();
+            let backtrace = std::backtrace::Backtrace::capture();
 
-            if matches!(backtrace.status(), BacktraceStatus::Captured) {
+            if backtrace.status() == std::backtrace::BacktraceStatus::Captured {
                 tracing::error!("{backtrace}");
-                // event!(Level::TRACE, "{backtrace}");
             }
         }
         MessageType::Other => {
-            create_event!(Level::INFO);
+            emit_log_with_message!(tracing::Level::INFO);
         }
         _ => {
-            create_event!(Level::WARN);
+            emit_log_with_message!(tracing::Level::WARN);
         }
     };
 }