| Age | Commit message (Collapse) | Author |
|---|
|
stopListening also disabled the interrupt, if needed, so calling that
function makes more sense. Since stopListening only disables the
interrupt when the current SoftwareSerial is the active object, and that
can only be the case when _rx_delay_stopbit is non-zero, there is no
need to separately check _rx_delay_stopbit anymore.
|
|
If an interrupt causing overflow would occur between reading
_buffer_overflow and clearing it, this overflow condition would be
immediately cleared and never be returned by overflow().
By only clearing the overflow flag if an overflow actually occurred,
this problem goes away (worst case overflow() returns false even though
an overflow _just_ occurred, but then the next call to overflow() will
return true).
|
|
This prevents interrupts from triggering when the SoftwareSerial
instance is not even listening.
Additionally, this removes the need to disable interrupts in
SoftwareSerial::listen, since no interrupts are active while it touches
the variables.
|
|
This allows one to explicitly stop a SoftwareSerial instance from
listening, without having to make another one listening.
|
|
This moves the interrupt mask enabling / disabling code into a separate
method, so we can call it from multiple spots next.
|
|
The current check is still always false when the old check was, but
additionally it will not disable the interrupts when they were never
enabled (which shouldn't matter much, but this is more consistent).
|
|
In this case, SoftwareSerial::begin will not have enabled the
interrupts, so better not allow the SoftwareSerial instance to enter the
listening state either.
|
|
Before enabling interupts, begin would see if the given receive pin
actually has an associated PCINT register. If not, the interrupts would
not be enabled.
Now, the same check is done, but when no register is available, the rx
parameters are not loaded at all (which in turn prevents the interrupt
from being enabled). This allows all code to use the same "is rx
enabled" (which will be added next).
|
|
|
|
Fixes #2538
|
|
Fixes #2151
Fixes #2147
|
|
Conflicts:
hardware/arduino/cores/arduino/wiring.c
libraries/Ethernet/src/utility/util.h
libraries/Ethernet/src/utility/w5100.cpp
libraries/Ethernet/src/utility/w5100.h
libraries/Ethernet/util.h
libraries/Ethernet/utility/util.h
libraries/SPI/SPI.cpp
libraries/SPI/SPI.h
|
|
|
|
(Andrew Kroll)
Previously, it could happen that SPI::beginTransaction was
interrupted by an ISR, while it is changing the SPI_AVR_EIMSK
register or interruptSave variable (it seems that there is
a small window after changing SPI_AVR_EIMSK where an interrupt
might still occur). If this happens, interruptSave is overwritten
with an invalid value, permanently disabling the pin interrupts.
To prevent this, disable interrupts globally while changing
these values.
|
|
|
|
|
|
|
|
From https://github.com/arduino/Arduino/pull/2376#issuecomment-59671152
Quoting Andrew Kroll:
[..this commit..] introduces a small delay that can prevent the wait
loop form iterating when running at the maximum speed. This gives
you a little more speed, even if it seems counter-intuitive. At
lower speeds, it is unnoticed. Watch the output on an oscilloscope
when running full SPI speed, and you should see closer back-to-back
writes.
Quoting Paul Stoffregen:
I did quite a bit of experimenting with the NOP addition. The one
that's in my copy gives about a 10% speedup on AVR.
|
|
|
|
|
|
|
|
Previously, when verbose uploads were enabled, avrdude was run with four
-v options, causing it to dump all raw bytes exchanged with the
bootloader. This floods the console so much that meaningful output
mostly disappears.
Most users probably want to enable verbose mode just to see what avrdude
command is ran. Furthermore, users that benefit from the raw bytes
dumped are perfectly capable of either running avrdude manually, or
modifying platform.txt. Given that, running avrdude with just one -v
should be plenty.
This fixes #891.
|
|
Conflicts:
hardware/arduino/cores/arduino/HardwareSerial.cpp
hardware/arduino/cores/robot/Arduino.h
|
|
This reverts commit f40e4713542fa862d5b99b256a642e001a796988.
Added an hint for the buffer sizes.
See #2057
Fixes #2367
|
|
Fixes #2379
|
|
Conflicts:
build/shared/examples/09.USB/Keyboard/KeyboardLogout/KeyboardLogout.ino
hardware/arduino/boards.txt
|
|
Add #include "Print.h" in Server.h Ide 1.5.x
|
|
|
|
Signed-off-by: Arnav Gupta <championswimmer@gmail.com>
|
|
Signed-off-by: Arnav Gupta <championswimmer@gmail.com>
|
|
Conflicts:
app/src/processing/app/Base.java
build/build.xml
todo.txt
|
|
|
|
Missing SPI Transaction API methods on Due (SAM3X)
|
|
Close #1847
|
|
String index fixes and cleanups
|
|
When checking the `left` argument, it previously allowed having
left == len. However, this means the substring starts one past the last
character in the string and should return the empty string. In practice,
this already worked correctly, because buffer[len] contains the trailing
nul, so it would (re)assign the empty string to `out`.
However, fixing this check makes it a bit more logical, and prevents a
fairly unlikely out-of-buffer write (to address 0x0) when calling
substring on an invalidated String:
String bar = (char*)NULL;
bar.substring(0, 0);
|
|
Fix for upload problems on Arduino Leonardo (and derivatives) on OSX 10.9
|
|
Previously, this method calculated the length of the string from the
given index onwards. However, the other remove() method called already
contains code for this calculation, which is used when the count passed
in is too big. This means we can just pass in a very big count that is
guaranteed to point past the end of the string, shrinking the remove
method by a few bytes.
|
|
Previously, if you passed in a very big index and/or count, the
`index + count` could overflow, making the count be used as-is instead
of being truncated (causing the string to be updated wrongly and
potentially writing to arbitrary memory locations).
We can rewrite the comparison to use `len - index` instead. Since we
know that index < len, we are sure this subtraction does not overflow,
regardless of what values of index and count we pass in.
As an added bonus, the `len - index` value already needed be calculated
inside the if, so this saves a few instructions in the generated code.
To illustrate this problem, consider this code:
String foo = "foo";
Serial.println(foo.length()); // Prints 3
foo.remove(1, 65535); // Should remove all but first character
Serial.println(foo.length()); // Prints 4 without this patch
Not shown in this is example is that some arbitrary memory is written
as well.
|
|
This check already happens in the remove(unsigned int, unsigned int)
method that is caled, so there is no need to also check this here.
|
|
|
|
The following empty stubs has been replaced by the gcc
flag -fno-threadsafe-static:
int __cxa_guard_acquire(__guard *);
void __cxa_guard_release (__guard *);
void __cxa_guard_abort (__guard *);
The following empty stubs has been moved into their specific
module abi.cpp:
void __cxa_pure_virtual(void) __attribute ((noreturn));
void __cxa_deleted_virtual(void) __attribute ((noreturn));
Fix #107
|
|
Probalby new.h may be removed completely.
|
|
|
|
|
|
|
|
|
|
This is an empty stub to simply allow use of complex types with a
non global static lifetime. For more complex handling the function
'atexit' can be redefined in user code.
For more information see:
https://github.com/arduino/Arduino/pull/2229
https://github.com/arduino/Arduino/issues/1919
|
|
|
|
|
