| Age | Commit message (Collapse) | Author |
|---|
|
String index fixes and cleanups
|
|
When checking the `left` argument, it previously allowed having
left == len. However, this means the substring starts one past the last
character in the string and should return the empty string. In practice,
this already worked correctly, because buffer[len] contains the trailing
nul, so it would (re)assign the empty string to `out`.
However, fixing this check makes it a bit more logical, and prevents a
fairly unlikely out-of-buffer write (to address 0x0) when calling
substring on an invalidated String:
String bar = (char*)NULL;
bar.substring(0, 0);
|
|
Fix for upload problems on Arduino Leonardo (and derivatives) on OSX 10.9
|
|
Previously, this method calculated the length of the string from the
given index onwards. However, the other remove() method called already
contains code for this calculation, which is used when the count passed
in is too big. This means we can just pass in a very big count that is
guaranteed to point past the end of the string, shrinking the remove
method by a few bytes.
|
|
Previously, if you passed in a very big index and/or count, the
`index + count` could overflow, making the count be used as-is instead
of being truncated (causing the string to be updated wrongly and
potentially writing to arbitrary memory locations).
We can rewrite the comparison to use `len - index` instead. Since we
know that index < len, we are sure this subtraction does not overflow,
regardless of what values of index and count we pass in.
As an added bonus, the `len - index` value already needed be calculated
inside the if, so this saves a few instructions in the generated code.
To illustrate this problem, consider this code:
String foo = "foo";
Serial.println(foo.length()); // Prints 3
foo.remove(1, 65535); // Should remove all but first character
Serial.println(foo.length()); // Prints 4 without this patch
Not shown in this is example is that some arbitrary memory is written
as well.
|
|
This check already happens in the remove(unsigned int, unsigned int)
method that is caled, so there is no need to also check this here.
|
|
|
|
The following empty stubs has been replaced by the gcc
flag -fno-threadsafe-static:
int __cxa_guard_acquire(__guard *);
void __cxa_guard_release (__guard *);
void __cxa_guard_abort (__guard *);
The following empty stubs has been moved into their specific
module abi.cpp:
void __cxa_pure_virtual(void) __attribute ((noreturn));
void __cxa_deleted_virtual(void) __attribute ((noreturn));
Fix #107
|
|
Probalby new.h may be removed completely.
|
|
|
|
|
|
|
|
This is an empty stub to simply allow use of complex types with a
non global static lifetime. For more complex handling the function
'atexit' can be redefined in user code.
For more information see:
https://github.com/arduino/Arduino/pull/2229
https://github.com/arduino/Arduino/issues/1919
|
|
|
|
|
|
Fix of a bug #2199
|
|
|
|
Ide 1.5.x lib description
|
|
Fix two compiler warnings generated by updated toolchain
|
|
|
|
|
|
|
|
Stream::find(char *target) passes an empty terminator string to
Stream::findUntil(char *target, char *terminator) which caused a compiler
warning with the updated toolchain, so cast it to a char*.
|
|
Enable user to change the I2C clock frequency by calling setClock in the Wire library
|
|
Arduino Pro and Pro Mini should use eightanaloginputs variant
|
|
|
|
|
|
File path should be updated, is wrong currently, will throw an error saying files missing.
|
|
|
|
|
|
benoit-artefactlabs/wifishield-upgrade-firmware-mac-path
corrected wrong path to firmware binaries in wifishield upgrade script f...
|
|
Conflicts:
app/src/processing/app/debug/Compiler.java
hardware/arduino/sam/cores/arduino/main.cpp
|
|
github.com:matthijskooijman/Arduino into matthijskooijman-ide-1.5.x-timer-variant
|
|
Allow variants to define an initVariant() function that is called at startup
|
|
worked out.
For more info:
https://groups.google.com/a/arduino.cc/d/msg/developers/21G5w2HbUOg/NRMW6c9OIFUJ
|
|
|
|
|
|
analog pins can be used
|
|
See #2080 for more details.
|
|
|
|
These chips were previously supported, but since parity error checking
was added, this support has broken. Most chips define UPE0 (etc.) for
the parity error bit. Some chips don't have numbered UARTS so only
define UPE and even fewer define PE instead of UPE. This adds support
for those chips again.
Closes: #2137
|
|
See #2080 and #2139.
|
|
|
|
this fix is just a workaround
|
|
warning http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59396
|
|
|
|
|
|
See #2080
|
|
|
|
See:
https://github.com/arduino/Arduino/commit/9ac7e30252fce5b9dafde3288519b020b73c37bd#commitcomment-6718676
|
