diff options
| author | Martino Facchin <m.facchin@arduino.cc> | 2015-09-21 11:59:20 +0200 |
|---|---|---|
| committer | Martino Facchin <m.facchin@arduino.cc> | 2015-09-21 11:59:20 +0200 |
| commit | e5685758e3015d276ac7b1ffe9fbea75e008fd9e (patch) | |
| tree | 78ea77b7444ba22160ac6504ab01e11a71e5e181 | |
| parent | 2453337d85e6eb07a7287c8d09adf9afb1bf13ca (diff) | |
fix pulseInLong considering overflow
fixes #3830
| -rw-r--r-- | cores/arduino/wiring_pulse.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/cores/arduino/wiring_pulse.c b/cores/arduino/wiring_pulse.c index 3212f13..d6e0434 100644 --- a/cores/arduino/wiring_pulse.c +++ b/cores/arduino/wiring_pulse.c @@ -69,22 +69,24 @@ unsigned long pulseInLong(uint8_t pin, uint8_t state, unsigned long timeout) uint8_t port = digitalPinToPort(pin); uint8_t stateMask = (state ? bit : 0); - unsigned long maxMicros = micros() + timeout; + unsigned long startMicros = micros(); // wait for any previous pulse to end - while ((*portInputRegister(port) & bit) == stateMask) - if (micros() > maxMicros) + while ((*portInputRegister(port) & bit) == stateMask) { + if (micros() - startMicros > timeout) return 0; + } // wait for the pulse to start - while ((*portInputRegister(port) & bit) != stateMask) - if (micros() > maxMicros) + while ((*portInputRegister(port) & bit) != stateMask) { + if (micros() - startMicros > timeout) return 0; + } unsigned long start = micros(); // wait for the pulse to stop while ((*portInputRegister(port) & bit) == stateMask) { - if (micros() > maxMicros) + if (micros() - startMicros > timeout) return 0; } return micros() - start; |