From 33f5395f99cf5f93d2e782933129ed5fc2fde091 Mon Sep 17 00:00:00 2001 From: HampusM Date: Sat, 2 Jul 2022 15:08:57 +0200 Subject: fix: prevent opening too large RLE files This will prevent heap-buffer-overflows from occuring when opening RLE files with pattern sizes exceeding the current terminal size --- src/game/game.cpp | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'src/game') diff --git a/src/game/game.cpp b/src/game/game.cpp index 05b02fd..9835fc5 100644 --- a/src/game/game.cpp +++ b/src/game/game.cpp @@ -613,12 +613,19 @@ void Game::_open_rle_file(CommandInfo::Options options) noexcept return; } + auto scene_matrix = _scene->get_matrix(); + + if (rle_matrix->get_size() > scene_matrix->get_size()) + { + _show_command_error("Error: The pattern in the RLE file is too large for the " + "current terminal size"); + return; + } + _return_to_normal_mode(); const auto previous_pos = _cursor_controller->where(); - auto scene_matrix = _scene->get_matrix(); - for (auto row : *rle_matrix) { for (auto &col : row) -- cgit v1.2.3-18-g5258