From 5c1c672e018e41e5c87a0263a851684a52d9c1fb Mon Sep 17 00:00:00 2001 From: HampusM Date: Sun, 27 Mar 2022 19:21:22 +0200 Subject: refactor: replace string matrix with template matrix --- src/engine/graphics/matrix.hpp | 53 ++++++++++++ src/engine/graphics/matrix.tpp | 156 ++++++++++++++++++++++++++++++++++ src/engine/graphics/string_matrix.cpp | 140 ------------------------------ src/engine/graphics/string_matrix.hpp | 52 ------------ 4 files changed, 209 insertions(+), 192 deletions(-) create mode 100644 src/engine/graphics/matrix.hpp create mode 100644 src/engine/graphics/matrix.tpp delete mode 100644 src/engine/graphics/string_matrix.cpp delete mode 100644 src/engine/graphics/string_matrix.hpp (limited to 'src/engine') diff --git a/src/engine/graphics/matrix.hpp b/src/engine/graphics/matrix.hpp new file mode 100644 index 0000000..2c9ba81 --- /dev/null +++ b/src/engine/graphics/matrix.hpp @@ -0,0 +1,53 @@ +#pragma once + +#include "interfaces/matrix.hpp" + +#include "engine/data/bounds.hpp" +#include "engine/data/vector2.hpp" +#include "engine/matrix_iterator.hpp" + +#include +#include + +template +class Matrix : public IMatrix +{ +public: + explicit Matrix(const Bounds &bounds) noexcept; + + Matrix(const Matrix &matrix) noexcept; + + Matrix(Matrix &&matrix) noexcept; + + ~Matrix() noexcept override; + + void fill(Element element) noexcept override; + + [[nodiscard]] Element get(const Vector2 &pos) const noexcept override; + + void set(const Vector2 &pos, Element element) noexcept override; + + [[nodiscard]] uint32_t get_row_cnt() const noexcept override; + + [[nodiscard]] uint32_t get_column_cnt() const noexcept override; + + [[nodiscard]] MatrixIterator begin() const noexcept override; + + [[nodiscard]] MatrixIterator end() const noexcept override; + + Matrix &operator=(const Matrix &rhs) noexcept; + + Matrix &operator=(Matrix &&rhs) noexcept; + +private: + gsl::owner _matrix; + + uint32_t _row_cnt; + uint32_t _column_cnt; + + void _delete_matrix() noexcept; + + void _copy_matrix_from(const Matrix &source) noexcept; +}; + +#include "matrix.tpp" diff --git a/src/engine/graphics/matrix.tpp b/src/engine/graphics/matrix.tpp new file mode 100644 index 0000000..e0e65bb --- /dev/null +++ b/src/engine/graphics/matrix.tpp @@ -0,0 +1,156 @@ +#pragma once + +#include "matrix.hpp" + +template +Matrix::Matrix(const Bounds &bounds) noexcept + : _matrix(new Element *[bounds.get_height()]), + _row_cnt(bounds.get_height()), + _column_cnt(bounds.get_width()) +{ + for (gsl::owner row = _matrix; row != _matrix + _row_cnt; row++) + { + *row = static_cast>(new Element[bounds.get_width()]); + } +}; + +template +Matrix::Matrix(const Matrix &matrix) noexcept + : _matrix(new Element *[matrix._row_cnt]), + _row_cnt(matrix._row_cnt), + _column_cnt(matrix._column_cnt) +{ + _copy_matrix_from(matrix); +} + +template +Matrix::Matrix(Matrix &&matrix) noexcept + : _matrix(matrix._matrix), _row_cnt(matrix._row_cnt), _column_cnt(matrix._column_cnt) +{ + matrix._matrix = nullptr; +} + +template +Matrix::~Matrix() noexcept +{ + _delete_matrix(); +} + +template +void Matrix::fill(Element element) noexcept +{ + for (auto row : *this) + { + for (auto &col : row) + { + col = element; + } + } +} + +template +Element Matrix::get(const Vector2 &pos) const noexcept +{ + + auto x = static_cast(pos.get_x()); + auto y = static_cast(pos.get_y()); + + // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) + return _matrix[y][x]; +} + +template +void Matrix::set(const Vector2 &pos, Element element) noexcept +{ + auto x = static_cast(pos.get_x()); + auto y = static_cast(pos.get_y()); + + // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) + _matrix[y][x] = element; +} + +template +uint32_t Matrix::get_row_cnt() const noexcept +{ + return _row_cnt; +} + +template +uint32_t Matrix::get_column_cnt() const noexcept +{ + return _column_cnt; +} + +template +MatrixIterator Matrix::begin() const noexcept +{ + return MatrixIterator(_matrix, _column_cnt); +} + +template +MatrixIterator Matrix::end() const noexcept +{ + return MatrixIterator(_matrix + _row_cnt, _column_cnt); +} + +template +Matrix &Matrix::operator=(const Matrix &rhs) noexcept +{ + if (&rhs != this) + { + _delete_matrix(); + + // NOLINTNEXTLINE(cppcoreguidelines-owning-memory) + _matrix = nullptr; + + _matrix = new Element *[rhs._row_cnt]; + _copy_matrix_from(rhs); + } + + return *this; +} + +template +Matrix &Matrix::operator=(Matrix &&rhs) noexcept +{ + if (&rhs != this) + { + _delete_matrix(); + + // NOLINTNEXTLINE(cppcoreguidelines-owning-memory) + _matrix = rhs._matrix; + + rhs._matrix = nullptr; + } + + return *this; +} + +template +void Matrix::_delete_matrix() noexcept +{ + for (gsl::owner row = _matrix; row != _matrix + _row_cnt; row++) + { + delete[](*row); + } + + delete[] _matrix; +} + +template +void Matrix::_copy_matrix_from(const Matrix &source) noexcept +{ + // NOLINTNEXTLINE(cppcoreguidelines-owning-memory) + gsl::owner source_row = source._matrix; + + for (gsl::owner row = _matrix; row != _matrix + _row_cnt; + row++, source_row++) + { + *row = static_cast>(new Element[_column_cnt]); + + // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) + auto *end = *source_row + _column_cnt; + + std::copy(*source_row, end, *row); + } +} diff --git a/src/engine/graphics/string_matrix.cpp b/src/engine/graphics/string_matrix.cpp deleted file mode 100644 index 3920b8e..0000000 --- a/src/engine/graphics/string_matrix.cpp +++ /dev/null @@ -1,140 +0,0 @@ -#include "string_matrix.hpp" - -#include -#include - -StringMatrix::StringMatrix(const Bounds &bounds) noexcept - : _matrix(new std::string_view *[bounds.get_height()]), - _row_cnt(bounds.get_height()), - _column_cnt(bounds.get_width()) -{ - for (gsl::owner row = _matrix; row != _matrix + _row_cnt; row++) - { - *row = static_cast>( - new std::string_view[bounds.get_width()]); - } -}; - -StringMatrix::StringMatrix(const StringMatrix &string_matrix) noexcept - : _matrix(new std::string_view *[string_matrix._row_cnt]), - _row_cnt(string_matrix._row_cnt), - _column_cnt(string_matrix._column_cnt) -{ - _copy_matrix_from(string_matrix); -} - -StringMatrix::StringMatrix(StringMatrix &&string_matrix) noexcept - : _matrix(string_matrix._matrix), - _row_cnt(string_matrix._row_cnt), - _column_cnt(string_matrix._column_cnt) -{ - string_matrix._matrix = nullptr; -} - -StringMatrix::~StringMatrix() noexcept -{ - _delete_matrix(); -} - -void StringMatrix::fill(std::string_view element) noexcept -{ - for (auto row : *this) - { - for (auto &col : row) - { - col = element; - } - } -} - -std::string_view StringMatrix::get(const Vector2 &pos) const noexcept -{ - - auto x = static_cast(pos.get_x()); - auto y = static_cast(pos.get_y()); - - // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) - return _matrix[y][x]; -} - -void StringMatrix::set(const Vector2 &pos, std::string_view element) noexcept -{ - auto x = static_cast(pos.get_x()); - auto y = static_cast(pos.get_y()); - - // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) - _matrix[y][x] = element; -} - -uint32_t StringMatrix::get_row_cnt() const noexcept -{ - return _row_cnt; -} - -uint32_t StringMatrix::get_column_cnt() const noexcept -{ - return _column_cnt; -} - -MatrixIterator StringMatrix::begin() const noexcept -{ - return MatrixIterator(_matrix, _column_cnt); -} - -MatrixIterator StringMatrix::end() const noexcept -{ - return MatrixIterator(_matrix + _row_cnt, _column_cnt); -} - -StringMatrix &StringMatrix::operator=(const StringMatrix &rhs) noexcept -{ - if (&rhs != this) - { - _delete_matrix(); - _matrix = nullptr; - - _matrix = new std::string_view *[rhs._row_cnt]; - _copy_matrix_from(rhs); - } - - return *this; -} - -StringMatrix &StringMatrix::operator=(StringMatrix &&rhs) noexcept -{ - if (&rhs != this) - { - _delete_matrix(); - _matrix = rhs._matrix; - rhs._matrix = nullptr; - } - - return *this; -} - -void StringMatrix::_delete_matrix() noexcept -{ - for (gsl::owner row = _matrix; row != _matrix + _row_cnt; row++) - { - delete[](*row); - } - - delete[] _matrix; -} - -void StringMatrix::_copy_matrix_from(const StringMatrix &source) noexcept -{ - gsl::owner source_row = source._matrix; - - for (gsl::owner row = _matrix; row != _matrix + _row_cnt; - row++, source_row++) - { - *row = static_cast>( - new std::string_view[_column_cnt]); - - // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) - auto *end = *source_row + _column_cnt; - - std::copy(*source_row, end, *row); - } -} diff --git a/src/engine/graphics/string_matrix.hpp b/src/engine/graphics/string_matrix.hpp deleted file mode 100644 index ff0939c..0000000 --- a/src/engine/graphics/string_matrix.hpp +++ /dev/null @@ -1,52 +0,0 @@ -#pragma once - -#include "interfaces/matrix.hpp" - -#include "engine/data/bounds.hpp" -#include "engine/data/vector2.hpp" -#include "engine/matrix_iterator.hpp" - -#include -#include -#include -#include - -class StringMatrix : public IMatrix -{ -public: - explicit StringMatrix(const Bounds &bounds) noexcept; - - StringMatrix(const StringMatrix &string_matrix) noexcept; - - StringMatrix(StringMatrix &&string_matrix) noexcept; - - ~StringMatrix() noexcept override; - - void fill(std::string_view element) noexcept override; - - [[nodiscard]] std::string_view get(const Vector2 &pos) const noexcept override; - - void set(const Vector2 &pos, std::string_view element) noexcept override; - - [[nodiscard]] uint32_t get_row_cnt() const noexcept override; - - [[nodiscard]] uint32_t get_column_cnt() const noexcept override; - - [[nodiscard]] MatrixIterator begin() const noexcept override; - - [[nodiscard]] MatrixIterator end() const noexcept override; - - StringMatrix &operator=(const StringMatrix &rhs) noexcept; - - StringMatrix &operator=(StringMatrix &&rhs) noexcept; - -private: - gsl::owner _matrix; - - uint32_t _row_cnt; - uint32_t _column_cnt; - - void _delete_matrix() noexcept; - - void _copy_matrix_from(const StringMatrix &source) noexcept; -}; -- cgit v1.2.3-18-g5258