From 4a01b84cabd20f063b59cf5a543317a690751861 Mon Sep 17 00:00:00 2001 From: "David A. Mellis" Date: Thu, 29 Nov 2012 13:48:01 -0500 Subject: Moving TXCO definition into HardwareSerial.cpp from HardwareSerial.h. Otherwise, you get an error when compiling for processors with no serial port because the header file is always compiled. See, for an example of the problem: https://github.com/damellis/attiny/issues/8 --- cores/arduino/HardwareSerial.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'cores/arduino/HardwareSerial.cpp') diff --git a/cores/arduino/HardwareSerial.cpp b/cores/arduino/HardwareSerial.cpp index 2e64acb..719f3f6 100644 --- a/cores/arduino/HardwareSerial.cpp +++ b/cores/arduino/HardwareSerial.cpp @@ -34,6 +34,22 @@ #include "HardwareSerial.h" +/* + * on ATmega8, the uart and its bits are not numbered, so there is no "TXC0" + * definition. It is slightly cleaner to define this here instead of having + * conditional code in the cpp module. + */ +#if !defined(TXC0) +#if defined(TXC) +#define TXC0 TXC +#elif defined(TXC1) +// Some devices have uart1 but no uart0 +#define TXC0 TXC1 +#else +#error TXC0 not definable in HardwareSerial.h +#endif +#endif + // Define constants and variables for buffering incoming serial data. We're // using a ring buffer (I think), in which head is the index of the location // to which to write the next incoming character and tail is the index of the -- cgit v1.2.3-18-g5258 From 9d638ca052d97843a9ba47040f6f60804a9d0dfe Mon Sep 17 00:00:00 2001 From: "David A. Mellis" Date: Thu, 29 Nov 2012 13:55:59 -0500 Subject: Clarifying comment. --- cores/arduino/HardwareSerial.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'cores/arduino/HardwareSerial.cpp') diff --git a/cores/arduino/HardwareSerial.cpp b/cores/arduino/HardwareSerial.cpp index 719f3f6..794a7be 100644 --- a/cores/arduino/HardwareSerial.cpp +++ b/cores/arduino/HardwareSerial.cpp @@ -36,8 +36,7 @@ /* * on ATmega8, the uart and its bits are not numbered, so there is no "TXC0" - * definition. It is slightly cleaner to define this here instead of having - * conditional code in the cpp module. + * definition. */ #if !defined(TXC0) #if defined(TXC) -- cgit v1.2.3-18-g5258